ci: make the Chromium regression suite merge-blocking#593
Conversation
The broad Chromium suite ran as "Advisory UI regression" with continue-on-error and no place in the required aggregate, so required CI could pass while real browser regressions failed (2026-07-13 audit, finding 8) — the stale /privacy heading assertion fixed here shipped exactly that way. Changes: - ui-regression now runs the stable set (test:e2e:regression, --grep-invert "@critical|@quarantine"), gates pr-required on UI changes, and matches ui-critical's trigger scope. - New advisory ui-quarantine job runs @quarantine-tagged specs (test:e2e:quarantine, --pass-with-no-tests). No test is quarantined at flip time: the full 142-test set was green locally after fixing the /privacy drift; three cold-server timing timeouts that pass warmed and have no CI failure history are documented as a watch-list in docs/process-hardening.md. - Fix the stale /privacy assertions in ui-smoke (page title is "Privacy & data handling" since the footer simplification). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
#593 already promoted ui-regression (test:e2e:regression with the @quarantine escape hatch); this branch keeps only its unique delta — the chromium-mockups project split, the advisory ui-mockups lane, and the cross-mode spec hardening. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 participant
Summary
2026-07-13 audit finding 8: the broad Chromium suite ran as "Advisory UI regression" with
continue-on-error: trueand no place in the required aggregate, so required CI could pass while real browser regressions failed — the stale/privacyheading assertion (independently fixed on main since) shipped exactly that way.ui-regressionnow runs the stable set viatest:e2e:regression(--grep-invert "@critical|@quarantine"), gatespr-requiredon UI changes, and matchesui-critical's trigger scope.ui-quarantinejob runs@quarantine-tagged specs (test:e2e:quarantine,--pass-with-no-tests)./privacydrift; three cold-dev-server timing timeouts pass on a warmed server and have no CI failure history, documented as a watch-list indocs/process-hardening.md(tag@quarantineif one flakes rather than reverting the gate).Verification
npm run check:github-actions,npm run check:ci-scope, YAML parse, schema/yaml-contract vitest suites on the rebased headtest:e2e:quarantineexits 0 with no tagged tests (--pass-with-no-tests)CI / PR required(no new required-context names)Notes
🤖 Generated with Claude Code